Skip to content

Conversation

@jatinderjit
Copy link
Contributor

@jatinderjit jatinderjit commented May 16, 2025

DayNight Toggle

A plugin to switch between Dark mode and Light mode.

@cibere
Copy link
Contributor

cibere commented May 16, 2025

Hello, and thank you for this plugin submission. Everything looks good to me, however is there is a specific reason for all of the default keywords? It seems a little excessive to me, especially since they all seem to do the same thing, and there is no way to either edit the keywords, or remove any that conflict with other plugins

@jatinderjit
Copy link
Contributor Author

jatinderjit commented May 16, 2025

Hi. Thanks for reviewing this.
I don't know what the standard practice is for the keywords. I just intended to make the search easy, so that there's not too much cognitive load to remember what the keyword is.

What I wanted was to start showing the option while the user is typing. For example, the results should appear when the user has typed lig. But I couldn't find a way as Flow seems to be keyword-oriented. So I added other shortcuts like "dn", "th".

Do you have any suggestions for me? Does one of these seem fine?

  1. day, night, dn, dark, light
  2. dark, light
  3. Just dn
  4. something else?

@jatinderjit jatinderjit reopened this May 16, 2025
@cibere
Copy link
Contributor

cibere commented May 16, 2025

Hi. Thanks for reviewing this.

I don't know what the standard practice is for the keywords. I just intended to make the search easy, so that there's not too much cognitive load to remember what the keyword is.

What I wanted was to start showing the option while the user is typing. For example, the results should appear when the user has typed lig. But I couldn't find a way as Flow seems to be keyword-oriented. So I added other shortcuts like "dn", "th".

Do you have any suggestions for me? Does one of these seem fine?

  1. day, night, dn, dark, light

  2. dark, light

  3. Just dn

  4. something else?

With the latest version of flow, if you only have one keyword, flow will make it easy for people to change it. However, having more than one registered makes flow hide this customization, and requires the plugin dev to implement it themselves. With that said, unless you either have a good reason for multiple, or you implement a way to edit the keywords, I'd like you to switch to a single keyword. Perhaps th or dn

@jatinderjit
Copy link
Contributor Author

implement a way to edit the keywords

I didn't know this was possible! I'll check that out.

Meanwhile, I've updated the plugin to use only one keyword dn.

@cibere
Copy link
Contributor

cibere commented May 27, 2025

Sorry for taking so long to merge this

@cibere cibere merged commit 6c4bbf2 into Flow-Launcher:plugin_api_v2 May 27, 2025
6 checks passed
@jatinderjit jatinderjit deleted the daynight-toggle branch May 28, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants